Update Firefox data for appearance: base-select#29780
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
data:css
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Firefox compatibility data for
appearance: base-selectand the single-dropdown customizable select subfeature.Details
Firefox bug 1974787 was fixed for Firefox 149 and added
appearance: base-selectbehindlayout.css.appearance-base-select.enabled. This updates the generalbase-selectvalue and the single-dropdown subfeature with the corresponding preference flag.I left the listbox and multiple-dropdown subfeatures unchanged because the Firefox bug documents the customizable
<select>value, but does not establish those separate subfeatures.Tests
npm run lint -- css/properties/appearance.jsonprettier --check css/properties/appearance.jsonnode -e "JSON.parse(require('fs').readFileSync('css/properties/appearance.json','utf8')); console.log('valid json')"git diff --checkRelated